Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Error: undefined method `overlap?' for nil:NilClass

#3

When parsing one my network configs (for a complex network) I get the following error twice, once for Team Cymru Bogons and once for non-routable addresses. Both return "unknown line" in the right column. I'll have to see about whether I can share the config.

undefined method overlap?' for nil:NilClass<br/> FIREWALL RULES<br/> Error running check rfc1918: undefined methodoverlap?' for nil:NilClass: ./../lib/flint/test.rb:248:in match_acl'../checks/pix/antispoof.ftg:25:inload'./../lib/flint/test.rb:397:in permit_map_select'./../lib/flint/test.rb:360:ineach_acl_of_applied_chains'./../lib/flint/test.rb:193:in each_acl_of'./../lib/flint/cisco_firewall.rb:428:ineach_rule_for_chain'./../lib/flint/cisco_firewall.rb:427:in each'./../lib/flint/cisco_firewall.rb:427:ineach_rule_for_chain'./../lib/flint/test.rb:192:in each_acl_of'./../lib/flint/test.rb:359:ineach_acl_of_applied_chains'./../lib/flint/test.rb:358:in each'./../lib/flint/test.rb:358:ineach_acl_of_applied_chains'./../lib/flint/test.rb:396:in permit_map_select'../checks/pix/antispoof.ftg:24:inload'./../lib/flint/test.rb:237:in instance_eval'./../lib/flint/test.rb:237:intest'./../lib/flint/test.rb:42:in orig_run'./../lib/flint/test.rb:343:inrun_iface'./../lib/flint/test.rb:428:in run'./../lib/flint/test.rb:427:ineach'./../lib/flint/test.rb:427:in run'./../lib/flint/test_runner.rb:22:inrun'./../lib/flint/test_runner.rb:19:in each'./../lib/flint/test_runner.rb:19:inrun'./lib/flint_hook.rb:23:in run'./lib/flint_hook.rb:20:ineach'./lib/flint_hook.rb:20:in run'./overview.rb:7:inGET /overview'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:779:in call'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:779:inroute'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:474:in instance_eval'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:474:inroute_eval'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:463:in route!'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:460:incatch'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:460:in route!'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:439:ineach'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:439:in route!'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:555:indispatch!'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:375:in call!'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:522:ininstance_eval'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:522:in invoke'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:522:incatch'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:522:in invoke'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/compat.rb:138:ininvoke'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:375:in call!'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:364:incall'/Users/hoffosjo/.gem/ruby/1.8/gems/rack-1.1.0/lib/rack/session/cookie.rb:37:in call'/Users/hoffosjo/.gem/ruby/1.8/gems/rack-1.1.0/lib/rack/showexceptions.rb:24:incall'/Users/hoffosjo/.gem/ruby/1.8/gems/rack-1.1.0/lib/rack/methodoverride.rb:24:in call'/Users/hoffosjo/.gem/ruby/1.8/gems/rack-1.1.0/lib/rack/commonlogger.rb:18:incall'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:898:in call'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:943:insynchronize'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:898:in call'/Users/hoffosjo/.gem/ruby/1.8/gems/rack-1.1.0/lib/rack/content_length.rb:13:incall'/Users/hoffosjo/.gem/ruby/1.8/gems/rack-1.1.0/lib/rack/chunked.rb:15:in call'/Users/hoffosjo/.gem/ruby/1.8/gems/rack-1.1.0/lib/rack/handler/mongrel.rb:67:inprocess'/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:159:in process_client'/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:ineach'/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in process_client'/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:inrun'/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in initialize'/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:innew'/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in run'/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:ininitialize'/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in new'/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:inrun'/Users/hoffosjo/.gem/ruby/1.8/gems/rack-1.1.0/lib/rack/handler/mongrel.rb:38:in run'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/base.rb:866:inrun!'/Users/hoffosjo/.gem/ruby/1.8/gems/sinatra-0.9.4/lib/sinatra/main.rb:34app.rb:51

Reported by jth · March 5th, 2010 @ 12:48 PM

State: resolved
Milestone: none
Assigned to: Craig Bugzefsky Craig Bugzefsky

Activity

  1. Craig Bugzefsky
    Craig Bugzefsky
    • State changed from new to open

    This is likely a result of us mishandling remarks.

    I'll confirm that once I have remark handling fixed.

    March 5th, 2010 @ 09:41 PM

  2. Craig Bugzefsky
    Craig Bugzefsky

    Does this go away once you strip out remarks, or run the 1.0.1 build with the improved punctuation handling?

    March 6th, 2010 @ 04:28 AM

  3. jth
    jth

    This goes away after stripping out remarks. Checking out new version now.

    March 6th, 2010 @ 04:58 AM

  4. jth
    jth

    Whoops, this one wasn't affected by remarks. Still checking new version now.

    March 6th, 2010 @ 04:59 AM

  5. jth
    jth

    Still getting wide variety of errors, different from overlap? error though.

    Error parsing network spec: ["DC-DMZPUB-NTP_Hosts", [:lineno, 621]]

    object-group network DC-DMZPUB-NTP_Hosts
    network-object 1.2.3.128 255.255.255.128 object-group network DC2-DMZPUB-NTP_Hosts
    network-object 2.3.4.128 255.255.255.128 object-group network OUR-NTP_Hosts
    group-object DC-DMZPUB-NTP_Hosts <--- line 621 group-object DC2-DMZPUB-NTP_Hosts

    Error running check redundant_rules:
    Error running check allow_any_service:
    Error when comparing destination_port of {:destination_net=>#, :destination_port=>#, :source_net=>#, :policy=>"permit", :acl_id=>"IN-OUTSIDE", :lineno=>697, "extended"=>nil, :protocol=>#} to {:destination_net=>#, :destination_port=>#, :source_net=>#, :policy=>"permit", :acl_id=>"IN-OUTSIDE", :lineno=>698, "extended"=>nil, :protocol=>#}

    -- config for that last one looks like the middle lines here (perhaps object-group again?):

    access-list IN-OUTSIDE remark Allow Inbound DC_Nets & Link Addresses ICMP
    access-list IN-OUTSIDE extended permit icmp object-group MnSCU_Nets any object-group ICMP-Allowed
    access-list IN-OUTSIDE extended permit icmp 123.45.0.0 255.255.0.0 any object-group ICMP-Allowed
    access-list IN-OUTSIDE extended permit icmp 67.89.0.0 255.255.0.0 any object-group ICMP-Allowed
    access-list IN-OUTSIDE extended permit icmp 234.56.7.0 255.255.255.224 any

    undefined method is_icmp?' for nil:NilClass

    Can't tell where this one occurred.

    March 6th, 2010 @ 05:16 AM

  6. Craig Bugzefsky
    Craig Bugzefsky

    Hmm, this error parsing network spec looks like something that should have been fixed by my push. That should have been coming in as [:object-group-ref "DC-DMZPUB-NTP_HOSTS"]

    Please check your version of lib/flint/cisco_firewall.rb

    and make sure that line 160 and 161 look like:

        # table member
          elsif ast[0].match(/^group-object$/i)
            current_group.add([:object_group_ref, ast[1]])
    

    I suspect your cisco_firewall.rb was not updated when you pulled (assuming you are using git).

    I'm on AIM too as cbrozefsky and google talk as craigbrozefsky if you wanna chat about this to resolve it quicker.

    March 8th, 2010 @ 04:45 PM

  7. Craig Bugzefsky
    Craig Bugzefsky

    I took your sample rules and created a firewall config to exercise them. I was not able to reproduce these errors. I think either I failed to previously push the changes, or your pull failed due to a local edit or something similiar.

    Let me know if there is anything else I can do. I'm leaving the bug unresolved for now.

    March 8th, 2010 @ 06:30 PM

  8. Craig Bugzefsky
    Craig Bugzefsky
    • State changed from open to resolved

    We fixed it, after flushing redis of all the cached data.

    March 9th, 2010 @ 09:21 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.